COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
48 stars 59 forks source link

Convergence on "formation" separation issue #518

Closed michaelzevin closed 3 years ago

michaelzevin commented 3 years ago

At L229 of utils.py, where convergence filters are being accounted for, the "formation" filter only includes systems with sep > 0. However, this throws out all systems that were disrupted, even if 2 is included in binary_state.

It would be better to remove the sep > 0 criterion, and if people want to only converge on the bound population, set porb > 0 in the convergence_limits.