search

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
46 stars 58 forks source link

it makes more sense to not include sep > 0 in this filtering #519

Closed katiebreivik closed 3 years ago

katiebreivik commented 3 years ago

This solves issue: #518 The previous code was particularly problematic for populations where you are interested in both the merging compact objects and the XRB population

codecov[bot] commented 3 years ago

Codecov Report

Merging #519 (0f14041) into develop (17193b9) will increase coverage by 0.00%. The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #519   +/-   ##
========================================
  Coverage    86.74%   86.74%           
========================================
  Files           40       40           
  Lines        25356    25362    +6     
========================================
+ Hits         21993    21999    +6     
  Misses        3363     3363
Impacted Files Coverage Δ
cosmic/utils.py 81.17% <ø> (ø)
cosmic/sample/initialcmctable.py 95.38% <0.00%> (+0.15%) :arrow_up:
cosmic/sample/initialbinarytable.py 94.44% <0.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 17193b9...0f14041. Read the comment docs.