COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
46 stars 58 forks source link

Critical Fix to virial radii #529

Closed carlrodriguez closed 3 years ago

carlrodriguez commented 3 years ago

need to switch kwargs.pop to kwargs.get, since the virial radius was used in multiple places.

codecov[bot] commented 3 years ago

Codecov Report

Merging #529 (5187d0c) into develop (a84237b) will increase coverage by 0.00%. The diff coverage is 100.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #529   +/-   ##
========================================
  Coverage    87.06%   87.07%           
========================================
  Files           40       40           
  Lines        25385    25391    +6     
========================================
+ Hits         22101    22107    +6     
  Misses        3284     3284           
Impacted Files Coverage Δ
cosmic/sample/sampler/cmc.py 84.04% <100.00%> (ø)
cosmic/sample/initialcmctable.py 95.49% <0.00%> (+0.14%) :arrow_up:
cosmic/sample/initialbinarytable.py 94.44% <0.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a84237b...5187d0c. Read the comment docs.

katiebreivik commented 3 years ago

looks good!