COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
46 stars 58 forks source link

didnt quite check for the attributes properly with qmin and m2_min #532

Closed katiebreivik closed 3 years ago

katiebreivik commented 3 years ago

This should finally do it!

codecov[bot] commented 3 years ago

Codecov Report

Merging #532 (2aff3ec) into develop (6699487) will increase coverage by 0.00%. The diff coverage is 50.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #532   +/-   ##
========================================
  Coverage    87.06%   87.06%           
========================================
  Files           40       40           
  Lines        25387    25393    +6     
========================================
+ Hits         22101    22107    +6     
  Misses        3286     3286           
Impacted Files Coverage Δ
cosmic/utils.py 80.86% <50.00%> (ø)
cosmic/sample/initialcmctable.py 95.49% <0.00%> (+0.14%) :arrow_up:
cosmic/sample/initialbinarytable.py 94.44% <0.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6699487...2aff3ec. Read the comment docs.

katiebreivik commented 3 years ago

Changes made @michaelzevin!