COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
46 stars 58 forks source link

Better reff #536

Closed carlrodriguez closed 3 years ago

carlrodriguez commented 3 years ago

Ok, I've managed to speed up the radii computation by 60x by exporting it into BSE, rather than using COSMIC's sampling for it. As a side note, this also eliminates the need to pass a params file or BSEDict when generating initial conditions

codecov[bot] commented 3 years ago

Codecov Report

Merging #536 (53f8ed9) into develop (915f7b5) will decrease coverage by 0.04%. The diff coverage is 66.67%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #536      +/-   ##
===========================================
- Coverage    87.06%   87.01%   -0.04%     
===========================================
  Files           40       40              
  Lines        25387    25341      -46     
===========================================
- Hits         22101    22050      -51     
- Misses        3286     3291       +5     
Impacted Files Coverage Δ
cosmic/sample/sampler/independent.py 59.60% <61.90%> (-7.55%) :arrow_down:
cosmic/sample/sampler/cmc.py 82.47% <100.00%> (+0.18%) :arrow_up:
cosmic/sample/initialcmctable.py 95.49% <0.00%> (+0.14%) :arrow_up:
cosmic/sample/initialbinarytable.py 94.44% <0.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 915f7b5...53f8ed9. Read the comment docs.

scottcoughlin2014 commented 3 years ago

This looks good!