search

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
48 stars 59 forks source link

ecsn fixes to fallback prescriptions #537

Closed michaelzevin closed 3 years ago

michaelzevin commented 3 years ago

Addressing #432

There seemed to be some adjustments to the Fryer fallback models for low core mass stars. I've changed so that it now follows Fryer+2012 directly, and also properly accounts for ECSN (including checking ecsn_mlow, which it wasn't doing before).

codecov[bot] commented 3 years ago

Codecov Report

Merging #537 (2f9bd49) into develop (e2966ac) will increase coverage by 0.02%. The diff coverage is 0.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #537      +/-   ##
===========================================
+ Coverage    87.01%   87.03%   +0.02%     
===========================================
  Files           40       40              
  Lines        25335    25335              
===========================================
+ Hits         22044    22050       +6     
+ Misses        3291     3285       -6
Impacted Files Coverage Δ
cosmic/src/hrdiag.f 39.54% <0.00%> (+0.30%) :arrow_up:
cosmic/sample/initialcmctable.py 95.49% <0.00%> (+0.14%) :arrow_up:
cosmic/sample/initialbinarytable.py 94.44% <0.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2966ac...2f9bd49. Read the comment docs.