search

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
46 stars 58 forks source link

fixes the elson profile problem I was talking about #538

Closed carlrodriguez closed 3 years ago

carlrodriguez commented 3 years ago

velocities for the plummer sphere are now sampled directly from the distribution function, instead of the numerical distribution function we were using for the Elson profile. Gives the same answer, but is faster and doesn't throw scipy integration warnings.

codecov[bot] commented 3 years ago

Codecov Report

Merging #538 (14209e0) into develop (e2966ac) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #538      +/-   ##
===========================================
+ Coverage    87.01%   87.03%   +0.02%     
===========================================
  Files           40       40              
  Lines        25335    25361      +26     
===========================================
+ Hits         22044    22071      +27     
+ Misses        3291     3290       -1
Impacted Files Coverage Δ
cosmic/sample/cmc/elson.py 89.63% <100.00%> (+2.67%) :arrow_up:
cosmic/sample/initialcmctable.py 95.49% <0.00%> (+0.14%) :arrow_up:
cosmic/sample/initialbinarytable.py 94.44% <0.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update e2966ac...14209e0. Read the comment docs.