search

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
46 stars 58 forks source link

Imf fix #540

Closed carlrodriguez closed 3 years ago

carlrodriguez commented 3 years ago

The kwargs for the custom IMF weren't actually being passed from CMC. I've updated the code to do that, and also clarified the documentation.

codecov[bot] commented 3 years ago

Codecov Report

Merging #540 (8f9114d) into develop (c68f682) will decrease coverage by 0.00%. The diff coverage is 58.33%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #540      +/-   ##
===========================================
- Coverage    87.03%   87.03%   -0.00%     
===========================================
  Files           40       40              
  Lines        25329    25340      +11     
===========================================
+ Hits         22044    22053       +9     
- Misses        3285     3287       +2
Impacted Files Coverage Δ
cosmic/sample/sampler/cmc.py 82.47% <ø> (ø)
cosmic/sample/sampler/independent.py 59.60% <58.33%> (+0.01%) :arrow_up:
cosmic/sample/initialcmctable.py 95.49% <0.00%> (+0.14%) :arrow_up:
cosmic/sample/initialbinarytable.py 94.44% <0.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update c68f682...8f9114d. Read the comment docs.

katiebreivik commented 3 years ago

thanks for catching this carl! I'll merge in now that the tests are passing.