search

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
46 stars 58 forks source link

correcting the upper end of the pisn gap in the Marchant+ prescription #545

Closed michaelzevin closed 2 years ago

michaelzevin commented 2 years ago

See Table 1 of Marchant+2019. We were accidentally using the column with CO core mass rather than the column with He core mass for defining the top of the PISN mass gap in the Marchant prescription.

codecov[bot] commented 2 years ago

Codecov Report

Merging #545 (6bc0009) into develop (447e18a) will increase coverage by 0.28%. The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #545      +/-   ##
===========================================
+ Coverage    87.01%   87.29%   +0.28%     
===========================================
  Files           40       40              
  Lines        25340    25346       +6     
===========================================
+ Hits         22049    22125      +76     
+ Misses        3291     3221      -70
Impacted Files Coverage Δ
cosmic/src/hrdiag.f 39.54% <ø> (ø)
cosmic/sample/initialcmctable.py 95.49% <0.00%> (+0.14%) :arrow_up:
cosmic/sample/initialbinarytable.py 94.44% <0.00%> (+0.16%) :arrow_up:
cosmic/evolve.py 84.58% <0.00%> (+29.17%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 447e18a...6bc0009. Read the comment docs.