COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
45 stars 58 forks source link

Fixing the final kstar range implement #549

Closed chiragchawla134 closed 2 years ago

codecov[bot] commented 2 years ago

Codecov Report

Merging #549 (85f3dba) into high_res_MW (61f3c1a) will increase coverage by 56.87%. The diff coverage is 59.28%.

Impacted file tree graph

@@               Coverage Diff                @@
##           high_res_MW     #549       +/-   ##
================================================
+ Coverage        29.95%   86.82%   +56.87%     
================================================
  Files               42       41        -1     
  Lines             7916    25413    +17497     
================================================
+ Hits              2371    22064    +19693     
+ Misses            5545     3349     -2196     
Impacted Files Coverage Δ
cosmic/FIRE.py 0.00% <0.00%> (ø)
cosmic/plotting.py 0.00% <0.00%> (ø)
cosmic/sample/sampler/__init__.py 100.00% <ø> (+100.00%) :arrow_up:
cosmic/src/benchmarkevolv2.f 100.00% <ø> (ø)
cosmic/src/hrdiag.f 39.54% <0.00%> (+12.29%) :arrow_up:
cosmic/src/mix.f 40.86% <12.50%> (+40.86%) :arrow_up:
cosmic/sample/sampler/multidim.py 17.33% <22.33%> (+17.33%) :arrow_up:
cosmic/src/comenv.f 34.02% <25.00%> (+20.43%) :arrow_up:
cosmic/evolve.py 55.42% <31.54%> (+55.42%) :arrow_up:
cosmic/Match.py 52.56% <34.29%> (+52.56%) :arrow_up:
... and 50 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update f074aac...85f3dba. Read the comment docs.

katiebreivik commented 2 years ago

ack! Looks like we broke the tests (which include the same bug that you fixed @chiragchawla134) I'll submit a quick test pr to fix this, then you can merge that, then we can merge. Apologies!