search

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
45 stars 58 forks source link

fixed the silly integration errors when sampling a Plummer profile #550

Closed carlrodriguez closed 2 years ago

carlrodriguez commented 2 years ago

Thought I already fixed this, but the PR from a few months ago was empty and the changes were actually sitting on my desktop. If gamma=4, the Elson profile will generate velocity samples directly from the Plummer distribution function (instead of numerically integrating the distribution function like it does for other cases)

codecov[bot] commented 2 years ago

Codecov Report

Merging #550 (836a7ed) into develop (3ecf9e1) will increase coverage by 0.01%. The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #550      +/-   ##
===========================================
+ Coverage    87.01%   87.02%   +0.01%     
===========================================
  Files           40       40              
  Lines        25347    25373      +26     
===========================================
+ Hits         22054    22080      +26     
  Misses        3293     3293
Impacted Files Coverage Δ
cosmic/sample/cmc/elson.py 88.89% <100.00%> (+1.93%) :arrow_up:
cosmic/sample/initialcmctable.py 95.49% <0.00%> (+0.14%) :arrow_up:
cosmic/sample/initialbinarytable.py 94.44% <0.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 3ecf9e1...836a7ed. Read the comment docs.