search

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
45 stars 58 forks source link

Wind prescription for very massive main-sequence stars #554

Closed poojanagrawal closed 1 year ago

poojanagrawal commented 2 years ago

Hi, I have been recently looking into mlwind.f in COSMIC and there seems to be an issue in the choice of Teff for Vink et al. (2001) winds. For very massive stars on main-sequence with Teff > 50000 K, the code should use Vink et al. (2001) winds (for windflag 2 and 3) if the conditions for LBV winds are not met. It, however, seems to be using Nieuwenhuijzen & de Jager (1990) winds (as L>4000Lsun).

katiebreivik commented 2 years ago

Thanks for flagging this @poojanagrawal! Sorry for the slow response time!

katiebreivik commented 2 years ago

Hey @poojanagrawal -- I assume that your last PR fixes this issue, but can you confirm that this is the case?

katiebreivik commented 1 year ago

I think this is all set from the previous release