search

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
45 stars 58 forks source link

Sse changes #555

Closed poojanagrawal closed 2 years ago

poojanagrawal commented 2 years ago

This pull request is for the following changes in mlwind.f.

  1. I have added zsun_wind to differentiate it from the global zsun variable and have set its value to 0.019 as wind mass-loss rates have originally been scaled from this value (e.g., see Section 4 of Vink et al. 2001).
  2. As described in Section 8 of Vink et al. 2001, the ratio of terminal velocity to escape velocity is dependent on metallicity by a factor of 0.13. Thus, I have added the appropriate scaling factor.
  3. Following the Dutch wind prescription of MESA, I have extended the use of Vink winds beyond 50 000K. This is only relevant for hot, very massive stars (M>150Msun), that have not yet reached the Eddington limit. Before this, winds from Nieuwenhuijzen & de Jager 1990 were getting used for such stars.
katiebreivik commented 2 years ago

Thanks for opening this @poojanagrawal! I remember from our chat that we'll need to update some of the unit tests. I'll have a careful look while the tests run.

codecov[bot] commented 2 years ago

Codecov Report

Merging #555 (cf3edcb) into develop (9fc54aa) will increase coverage by 1.18%. The diff coverage is 85.71%.

@@             Coverage Diff             @@
##           develop     #555      +/-   ##
===========================================
+ Coverage    87.07%   88.25%   +1.18%     
===========================================
  Files           40       40              
  Lines        25366    25379      +13     
===========================================
+ Hits         22086    22398     +312     
+ Misses        3280     2981     -299
Impacted Files Coverage Δ
cosmic/src/mlwind.f 45.13% <83.33%> (+2.54%) :arrow_up:
cosmic/utils.py 80.23% <100.00%> (+0.06%) :arrow_up:
cosmic/sample/initialcmctable.py 95.49% <0.00%> (+0.14%) :arrow_up:
cosmic/sample/initialbinarytable.py 94.44% <0.00%> (+0.16%) :arrow_up:
cosmic/src/evolv2.f 58.05% <0.00%> (+0.33%) :arrow_up:
cosmic/src/kick.f 75.98% <0.00%> (+1.57%) :arrow_up:
cosmic/evolve.py 89.58% <0.00%> (+34.17%) :arrow_up:
cosmic/sample/sampler/multidim.py 86.49% <0.00%> (+68.92%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 9fc54aa...cf3edcb. Read the comment docs.

katiebreivik commented 2 years ago

Alrighty this is good to go!