Orbital sample error in renzo19

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)

GNU General Public License v3.0

45 stars 58 forks source link

Orbital sample error in renzo19 #558

Closed elenagonzalez870 closed 1 year ago

elenagonzalez870 commented 2 years ago

When trying to sample orbits using the Renzo19 model, there's an error (image attached). I believe it is fixed by setting b=log10_porb_max to b=log10_porb_max[ind_massive] in the independent.py file

katiebreivik commented 2 years ago

Thank you for opening this @elenagonzalez870 !

I'd love to help make sure that you maintain credit for finding the bug and a fix! Do you mind submitting a pull request with these changes?

katiebreivik commented 1 year ago

this is now fixed here: https://github.com/COSMIC-PopSynth/COSMIC/pull/563