COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
45 stars 58 forks source link

Fixed orbital sampling in renzo19 #560

Closed elenagonzalez870 closed 1 year ago

elenagonzalez870 commented 2 years ago

Opened issue #558 . This fixes the orbital period sampling for renzo19.

codecov[bot] commented 1 year ago

Codecov Report

Merging #560 (7bb0650) into develop (428a66a) will decrease coverage by 0.05%. The diff coverage is 50.00%.

@@             Coverage Diff             @@
##           develop     #560      +/-   ##
===========================================
- Coverage    88.25%   88.20%   -0.05%     
===========================================
  Files           40       40              
  Lines        25373    25381       +8     
===========================================
- Hits         22392    22387       -5     
- Misses        2981     2994      +13     
Impacted Files Coverage Δ
cosmic/sample/sampler/independent.py 63.88% <50.00%> (-0.09%) :arrow_down:
cosmic/evolve.py 84.58% <0.00%> (-5.00%) :arrow_down:
cosmic/sample/sampler/cmc.py 82.47% <0.00%> (ø)
cosmic/sample/initialcmctable.py 95.49% <0.00%> (+0.14%) :arrow_up:
cosmic/sample/initialbinarytable.py 94.44% <0.00%> (+0.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 428a66a...7bb0650. Read the comment docs.

katiebreivik commented 1 year ago

This is now superseded by the previously merged PR, so I'll close here.