COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
45 stars 58 forks source link

Convergence calculation hangs when NS/BH populations are run with cosmic-pop #561

Open katiebreivik opened 1 year ago

katiebreivik commented 1 year ago

If a user specifies that they want to simulate NS and BH populations in a single cosmic-pop run, the Knuth binwidth calculation takes a long time (sometimes days (!)) to compute the binwidth for the mass histograms in the convergence calculation. This makes the calculation intractable and we should probably generate some warnings for folks who are trying to do this.

Some options for warnings: (1) warn when 13 and 14 are specified for final kstars (2) warn when mass ranges below 3Msun and above 3Msun in convergence calculation

An option for future catches: (1) split the match calculation for NS/BH masses up for > 3 Msun and < 3 Msun similar to eccentricity catches