codecov[bot]
commented
1 year ago Codecov Report
Base: 87.03% // Head: 86.98% // Decreases project coverage by -0.05% :warning:
Coverage data is based on head (
00e78b7) compared to base (1bc7386). Patch coverage: 75.00% of modified lines in pull request are covered.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #578 +/- ## =========================================== - Coverage 87.03% 86.98% -0.05% =========================================== Files 39 40 +1 Lines 25412 25417 +5 =========================================== - Hits 22116 22108 -8 - Misses 3296 3309 +13 ``` | [Impacted Files](https://codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth) | Coverage Δ | | |---|---|---| | [cosmic/src/evolv2.f](https://codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth#diff-Y29zbWljL3NyYy9ldm9sdjIuZg==) | `57.15% <ø> (-0.32%)` | :arrow_down: | | [cosmic/utils.py](https://codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth#diff-Y29zbWljL3V0aWxzLnB5) | `80.16% <ø> (-0.06%)` | :arrow_down: | | [cosmic/src/mlwind.f](https://codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth#diff-Y29zbWljL3NyYy9tbHdpbmQuZg==) | `42.06% <75.00%> (-3.08%)` | :arrow_down: | | [cosmic/src/kick.f](https://codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth#diff-Y29zbWljL3NyYy9raWNrLmY=) | `74.74% <0.00%> (-1.30%)` | :arrow_down: | | [cosmic/sample/cmc/elson.py](https://codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth#diff-Y29zbWljL3NhbXBsZS9jbWMvZWxzb24ucHk=) | `88.24% <0.00%> (-0.65%)` | :arrow_down: | | [cosmic/bse\_utils/zdata.py](https://codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth#diff-Y29zbWljL2JzZV91dGlscy96ZGF0YS5weQ==) | `100.00% <0.00%> (ø)` | | | [cosmic/bse\_utils/zcnsts.py](https://codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth#diff-Y29zbWljL2JzZV91dGlscy96Y25zdHMucHk=) | `100.00% <0.00%> (ø)` | | | [cosmic/\_\_init\_\_.py](https://codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/578?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth#diff-Y29zbWljL19faW5pdF9fLnB5) | `100.00% <0.00%> (ø)` | | Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth):umbrella: View full report at Codecov.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
During the UCB code comparison project from the LISA Astrophysics working group, I figured out that changing zsun_wind to a fixed 0.019 significantly changes the white dwarf masses away from 'stock BSE'. I've decided to remove zsun_wind from mlwind.f in favor of updated documentation.
I've also incorporated the NaN catch in cosmic-pop and added some logfile info. This is probably relevant for @TomWagg / https://github.com/TomWagg/cosmic-gala since @NatalieGottschlich and I tracked down the cause of the NaNs to be tied to pts1 in the case of DWD progenitors.