search

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
45 stars 58 forks source link

nan radius fixes #581

Closed elenagonzalez870 closed 9 months ago

elenagonzalez870 commented 1 year ago

I was getting nan radii for rare systems where a system of massive stars undergo common envelope and one of the stars undergoes a PISN. Then, that object is assigned a current mass value of mt = 0, which results in a negative remnant mass value in line 1175 of the hrdiag.f file. To fix this, I propose to add an additional if statement that first checks if the rembar-massloss value is greater than mt to avoid a negative mrem value.

codecov[bot] commented 1 year ago

Codecov Report

Patch coverage has no change and project coverage change: -0.15 :warning:

Comparison is base (66def00) 87.12% compared to head (44f8b6b) 86.97%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #581 +/- ## =========================================== - Coverage 87.12% 86.97% -0.15% =========================================== Files 40 40 Lines 25386 25405 +19 =========================================== - Hits 22117 22095 -22 - Misses 3269 3310 +41 ``` | [Impacted Files](https://codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/581?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth) | Coverage Δ | | |---|---|---| | [cosmic/src/hrdiag.f](https://codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/581?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth#diff-Y29zbWljL3NyYy9ocmRpYWcuZg==) | `39.14% <0.00%> (-0.40%)` | :arrow_down: | ... and [6 files with indirect coverage changes](https://codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/581/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth) Help us with your feedback. Take ten seconds to tell us [how you rate us](https://about.codecov.io/nps?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth). Have a feature suggestion? [Share it here.](https://app.codecov.io/gh/feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth)

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.

katiebreivik commented 9 months ago

Hey @elenagonzalez870 -- I'm going to close this for now. If you run into the problem again, we can open a new PR.