codecov[bot]
commented
1 year ago Codecov Report
Patch coverage: 100.00% and no project coverage change.
Comparison is base (
6367187) 86.91% compared to head (06cbaca) 86.91%.
Additional details and impacted files
```diff @@ Coverage Diff @@ ## develop #589 +/- ## ======================================== Coverage 86.91% 86.91% ======================================== Files 40 40 Lines 25440 25440 ======================================== Hits 22111 22111 Misses 3329 3329 ``` | [Impacted Files](https://app.codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth) | Coverage Δ | | |---|---|---| | [cosmic/src/evolv2.f](https://app.codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth#diff-Y29zbWljL3NyYy9ldm9sdjIuZg==) | `56.75% <ø> (ø)` | | | [cosmic/src/comenv.f](https://app.codecov.io/gh/COSMIC-PopSynth/COSMIC/pull/589?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=COSMIC-PopSynth#diff-Y29zbWljL3NyYy9jb21lbnYuZg==) | `34.02% <100.00%> (ø)` | |:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Do you have feedback about the report comment? Let us know in this issue.
Common envelope calculations when initiated by the secondary were buggy; j1 and j2 were used incorrectly at two places. To fix this, I have swapped j1 and j2, formation (j1) and formation(j2) in call to the comenv in evolv2.f when common envelope is initiated by the secondary in a contact system. Similarly, id for first star in CE (star responsible for CE) was always assumed to be 1 when calling hrdiag through comenv.f. This is again incorrect in the above case. I have modified the call the hrdiag to use star1 and star 2 instead.