COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
48 stars 59 forks source link

Timestep conditions: implement validation, add `teff` as an option #610

Closed TomWagg closed 10 months ago

TomWagg commented 10 months ago

Two main sets of changes here:

I also added some instructions to checkstate.f in case anyone else needs to add more condition variables one day.

p.s. This is my first attempt at coding in fortran so please do check I didn't break something (it doesn't seem like I have but just in case).

This will fix #609

codecov[bot] commented 10 months ago

Codecov Report

Attention: 306 lines in your changes are missing coverage. Please review.

Comparison is base (8772c07) 86.91% compared to head (a2f556c) 87.74%. Report is 22 commits behind head on develop.

Files Patch % Lines
cosmic/src/assign_remnant.f 9.39% 193 Missing :warning:
cosmic/src/zfuncs.f 6.67% 84 Missing :warning:
cosmic/src/hrdiag_remnant.f 64.00% 18 Missing :warning:
cosmic/checkstate.py 25.00% 3 Missing :warning:
cosmic/src/checkstate.f 0.00% 3 Missing :warning:
cosmic/src/evolv2.f 0.00% 3 Missing :warning:
cosmic/evolve.py 0.00% 1 Missing :warning:
cosmic/utils.py 85.71% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #610 +/- ## =========================================== + Coverage 86.91% 87.74% +0.83% =========================================== Files 40 42 +2 Lines 25542 25695 +153 =========================================== + Hits 22198 22544 +346 + Misses 3344 3151 -193 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.