search

COSMIC-PopSynth / COSMIC

COSMIC (Compact Object Synthesis and Monte Carlo Investigation Code)
GNU General Public License v3.0
48 stars 59 forks source link

Added a flag wd_mass_lim #616

Closed claireshiye closed 6 months ago

claireshiye commented 7 months ago

Added a flag wd_mass_lim controlling if massive remnants (>Mch) from MIC are allowed.

Fixed a bug in evolv2.f where in elseif(kstar(j1).eq.10.or.kstar(j2).gt.10)then the or should be and.

The effects of the flag are partially demonstrated in this paper https://ui.adsabs.harvard.edu/abs/2024ApJ...961...98Y/abstract.

katiebreivik commented 6 months ago

👍

codecov[bot] commented 6 months ago

Codecov Report

Attention: Patch coverage is 96.88716% with 8 lines in your changes are missing coverage. Please review.

Project coverage is 87.72%. Comparing base (8772c07) to head (30d958f). Report is 28 commits behind head on develop.

Files Patch % Lines
cosmic/src/evolv2.f 0.00% 5 Missing :warning:
cosmic/evolve.py 0.00% 1 Missing :warning:
cosmic/src/hrdiag_remnant.f 66.67% 1 Missing :warning:
cosmic/utils.py 75.00% 1 Missing :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## develop #616 +/- ## =========================================== + Coverage 86.91% 87.72% +0.81% =========================================== Files 40 42 +2 Lines 25542 25999 +457 =========================================== + Hits 22198 22806 +608 + Misses 3344 3193 -151 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.