search

COVESA / capicxx-someip-tools

Common API C++ SOMEIP tooling
Mozilla Public License 2.0
76 stars 55 forks source link

Typo in HelloWorld.depl from tutorial "CommonAPI C++ SOME/IP in 10 minutes" #19

Closed oneoftheshepherdssheep closed 1 year ago

oneoftheshepherdssheep commented 3 years ago

In the tutorial "CommonAPI C++ SOME/IP in 10 minutes", the example deployment file (HelloWorld.depl) has a typo (or maybe it is not up to date). There is a missing "as". I think it should be:

define org.genivi.commonapi.someip.deployment for provider as MyService {

instead of:

define org.genivi.commonapi.someip.deployment for provider MyService {

I had an issue with 3.2.0.1 of the generator and adding the "as" solve the issue. What do you think?

kkretsch commented 3 years ago

The as seems to be needed since version 3.2 of the generator. With the latest 3.1 is has to be removed.

Isn't there any standard defining which is right?

dibpinto commented 1 year ago

Correction done in the deployment file HelloWorld.fdepl for: define org.genivi.commonapi.someip.deployment for provider as MyService {