COVESA / capicxx-wamp-runtime

Common API runtime with WAMP messaging
Mozilla Public License 2.0
10 stars 10 forks source link

Question about CMake convention and build instruction #8

Open gunnarx opened 6 years ago

gunnarx commented 6 years ago

The README says to do these steps:

$ cd capicxx-wamp-runtime
$ mkdir build

<- Here you must mean to also cd into build/ first, right?

$ cmake -D USE_INSTALLED_COMMONAPI=ON -D CMAKE_INSTALL_PREFIX=/usr/local ..
$ make
$ make install

At the end this is written out: "Build files have been written to: /home/user/devel/GENIVI/capicxx-wamp-runtime"
<- Note - not written to /build

  1. I thought the more common way is that Makefile(s) are generated inside the build/ directory? That seems to be the point of creating the directory and also what I see from other cmake projects.

  2. I suppose this way is fine too, but then why not simply "cmake ." in root instead of "cmake .." inside of build...

kbirken commented 6 years ago

Thanks for the remark - yes, cd into build was missing. Corrected.

gunnarx commented 6 years ago

Even if you cd into build, the files seem to be generated not in build, but in the root. So, either they should generate inside build, or you need to also add "cd .." before doing make. (But that still leaves an empty build directory, which seems a bit useless?)