Open arshad1990 opened 5 years ago
Hey Arshad. Thanks for this PR. I'll check with kbirken if he has missed reviewing and merging this!?
And I can take a look myself, but I'm not an expert on this code base.
For the commit message I would suggest following best practices of a shorter title, less than 72 characters.
It seems to me that the "zip file" part is not so important perhaps, so may I suggest a title like: "Add command-line generator executables" (if these did not exist before?)
The sentence "Work done as part of this change request:" is also not necessary. Just provide the relevant information.
git suggests there are a few "whitespace errors", but I'm not sure how much of that already exists in the code base and if it's worth fixing here, or to fix in the whole code base instead.
@gunnarx I didn't miss it, reviewing and merging is still on my todo list. :-)
Work done as part of this change request: