search

COVESA / capicxx-wamp-tools

Common API tooling with WAMP messaging
Mozilla Public License 2.0
12 stars 7 forks source link

Generation of zip file which contains linux and windows executables for Wamp Generator #37

Open arshad1990 opened 5 years ago

arshad1990 commented 5 years ago

Work done as part of this change request:

  1. Creation of WAMP cli product
  2. Creation of WAMP cli feature
  3. Change of command line option from -f to -sp for input fidl files.
  4. Validation trigger in CommandLineHandlerWamp to trigger validation written in ValidatorWamp.
  5. Generation of Windows and Linux executables and packaged into zip.
  6. Removal of Standalone jar generation (from pom). Java code still exists.
  7. Tycho version change and some build issues.
gunnarx commented 5 years ago

Hey Arshad. Thanks for this PR. I'll check with kbirken if he has missed reviewing and merging this!?

And I can take a look myself, but I'm not an expert on this code base.

For the commit message I would suggest following best practices of a shorter title, less than 72 characters.

It seems to me that the "zip file" part is not so important perhaps, so may I suggest a title like: "Add command-line generator executables" (if these did not exist before?)

The sentence "Work done as part of this change request:" is also not necessary. Just provide the relevant information.

git suggests there are a few "whitespace errors", but I'm not sure how much of that already exists in the code base and if it's worth fixing here, or to fix in the whole code base instead.

kbirken commented 5 years ago

@gunnarx I didn't miss it, reviewing and merging is still on my todo list. :-)