daemon: refactor IPC usage

COVESA / dlt-daemon

Diagnostic Log and Trace.

https://covesa.github.io/dlt-daemon/

Mozilla Public License 2.0

381 stars 295 forks source link

daemon: refactor IPC usage #664

Open duvanan13 opened 4 months ago

duvanan13 commented 4 months ago

Prevent new daemon initialization when using FIFO
Unit test gateway IPC changes to UNIX_SOCKET
Shared memory is used for multinode testing
Resolve the TOCTOU issue

minminlittleshrimp commented 4 months ago

Thanks @duvanan13 for joining the pair programming section. I believe now you have more experience with source control using git. Thank you for your the rework on this issue, let see how Michael comment about this fix.

Hello @michael-methner , could you kindly review this fix? Thank you

michael-methner commented 4 months ago

Hello @duvanan13 , hello @minminlittleshrimp , this patch prevents are restart after dlt-daemon was not shutdown gracefully (e.g. due to a segmentation fault). Could modify the check so it checks for a running instance of dlt-daemon instead of the files present?

duvanan13 commented 4 months ago

Hello @michael-methner , In the dlt_daemon_signal_handler function in daemon, we've already implemented the unlink for FIFO by calling dlt_daemon_exit_trigger. Hence, my point is to add SIGSEGV to the dlt_daemon_signal_handler: https://github.com/COVESA/dlt-daemon/blob/358ab0879dd27b40a9ba4c411c86f7f017e989b5/src/daemon/dlt-daemon.c#L2135 Please kindly check my point.