search

COVESA / dlt-viewer

Diagnostic Log and Trace viewing program
Other
425 stars 240 forks source link

Zero Termination displayed as space #376

Closed smarkwardt closed 12 months ago

smarkwardt commented 1 year ago

Wrong Space in decoded Payload when an argument of type string is followed by an argument of an other type. dlt_001

alexmucde commented 12 months ago

@smarkwardt Please tell me to which plugin etc. this issue is related? Is this an open source plugin?

smarkwardt commented 12 months ago

@alexmucde I think it's a basic functionality of the dlt-viewer and not a plugin.

The spaces are incorrectly displayed by the dlt viewer.

DLT_LOG(mycontext, DLT_LOG_INFO, DLT_STRING("val: '"), DLT_INT(1), DLT_STRING("'"));
DLT_LOG(mycontext, DLT_LOG_INFO, DLT_STRING("aaa"), DLT_STRING("bbb"));

Screenshot 2023-09-18 153300

From my point of view, it is unfavorable because you have to take the unnecessary spaces in the filter query into account.

alexmucde commented 12 months ago

Thanks for the detailed explanation. Now i understand better your issue. Arguments of a DLT messages are separated by a space, when converted to ASCII. This feature is implemented since the beginning of the DLT Viewer development. The users of the DLT Viewer are used to this feature. Other logging frameworks like Qt Logging behave the same.

smarkwardt commented 12 months ago

It's not a bug, It's a Feature :/

Thanks for the clarification :) 👍