search

COVESA / dlt-viewer

Diagnostic Log and Trace viewing program
Other
425 stars 240 forks source link

filetransferplugin: Present save popup once #392

Closed mfukar closed 9 months ago

mfukar commented 9 months ago

The plugin's save command created a window for every successful or erroneous attempt to save individual files selected. This is tedious for more than a few files.

Instead, collect errors and present a single pop-up window.

In the future, an alternative might be to configure a selection between this behaviour and a brief message in the status bar.

Fixes a bug where doFLDA was erroneously called on messages ending a transfer ("FLFI..."), causing completed status for a file to be incorrect and display inconsistently.

Adds FiletransferPlugin::doFLFI which emits a new signal so that Form::finishfile_slot can record completion properly and auto-save if needed. updatefile_slot now tracks received packages and completion is ONLY recorded if a FLFI message is present.

alexmucde commented 9 months ago

@mfukar Is it possible to add a signed off statement?

alexmucde commented 9 months ago

@mfukar Oh sorry i have overseen, you have already done.