COVESA / dlt-viewer

Diagnostic Log and Trace viewing program
Other
420 stars 238 forks source link

qt6 #405

Open hannesa2 opened 7 months ago

hannesa2 commented 7 months ago

It's about to make CI work again with qt6

hannesa2 commented 7 months ago

close #408

hannesa2 commented 7 months ago

Now it runs into https://github.com/COVESA/dlt-viewer/actions/runs/7472144239/job/20333730632?pr=405

CMake Warning at scripts/windows/version.cmake:12 (find_package):
  Found package configuration file:

    D:/a/dlt-viewer/Qt/6.6.1/msvc2019_64/lib/cmake/Qt6/Qt6Config.cmake

  but it set Qt6_FOUND to FALSE so package "Qt6" is considered to be NOT
  FOUND.  Reason given by package:

  Failed to find required Qt component "SerialPort".

  Expected Config file at
  "D:/a/dlt-viewer/Qt/6.6.1/msvc2019_64/lib/cmake/Qt6SerialPort/Qt6SerialPortConfig.cmake"
  does NOT exist

  Configuring with --debug-find-pkg=Qt6SerialPort might reveal details why
  the package was not found.

  Configuring with -DQT_DEBUG_FIND_PACKAGE=ON will print the values of some
  of the path variables that find_package uses to try and find the package.

Call Stack (most recent call first):
  CMakeLists.txt:19 (include)

CMake Error at scripts/windows/version.cmake:21 (find_package):
  By not providing "FindQt5.cmake" in CMAKE_MODULE_PATH this project has
  asked CMake to find a package configuration file provided by "Qt5", but
  CMake did not find one.

  Could not find a package configuration file provided by "Qt5" (requested
  version 5) with any of the following names:

    Qt5Config.cmake
    qt5-config.cmake

  Add the installation prefix of "Qt5" to CMAKE_PREFIX_PATH or set "Qt5_DIR"
  to a directory containing one of the above files.  If "Qt5" provides a
  separate development package or SDK, be sure it has been installed.

I've no experience with qt. Who ever knows what wrong here, please help me/us to make CI work here again

bunty95 commented 5 months ago

Installing QT 5 along with QT 6 should solve the problem that you are facing. Also QT Build on MAC OS is only using QT 5. It needs to be changed to include both QT5 and QT 6.

bunty95 commented 4 weeks ago

@hannesa2 seems like the issue on macOS is related to cPack not finding the framework directory. Do you know where we call out the QT framework?

hannesa2 commented 4 weeks ago

Sorry, I've no clue about this

bunty95 commented 1 week ago

build issue is due to "macdeployqt" not being found. Hard coding a location to "/scripts/darwin/macdeployqt.cmake.in" fixes the issue. set(MACDEPLOYQT_EXECUTABLE "/usr/local/Cellar/qt/6.7.0_1/bin/macdeployqt") <- makes the build succeed, still need to confirm if it is able to run.