search

COVESA / dlt-viewer

Diagnostic Log and Trace viewing program
Other
432 stars 242 forks source link

fix Sorting by Lifecycle, startup time #307 #463

Closed eaj40 closed 2 months ago

eaj40 commented 5 months ago

fix #307

alexmucde commented 5 months ago

I do not see any useful code in there wich solves any issue or provides any new functionality.

eaj40 commented 5 months ago

Search for ISSUE_307 in src/mainwindow.cpp,, only one line of change, rest are for debugging

alexmucde commented 5 months ago

@eaj40 I still do not know how this PR will solve the issue. Identifying lifecycles in a DLT file is a complex topic and cannot be solved by a single line. 1) The Lifecycles of the DLT must be identified 2) Sorting by timestamp must be done based on the identified lifecycles

The current implemented feature sorting by Timestamp is ignoring several lifecycles.

eaj40 commented 5 months ago

What do you mean by Lifecycles

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: Alexander Wenzel @.> Sent: Tuesday, May 7, 2024 7:10:45 PM To: COVESA/dlt-viewer @.> Cc: eaj40 @.>; Mention @.> Subject: Re: [COVESA/dlt-viewer] fix Sorting by Lifecycle, startup time #307 (PR #463)

@eaj40https://github.com/eaj40 I still do not know how this PR will solve the issue. Identifying lifecycles in a DLT file is a complex topic and cannot be solved by a single line.

  1. The Lifecycles of the DLT must be identified
  2. Sorting by timestamp must be done based on the identified lifecycles

— Reply to this email directly, view it on GitHubhttps://github.com/COVESA/dlt-viewer/pull/463#issuecomment-2098437295, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADY65DHHBMGYENBY6LUZFDDZBDKV3AVCNFSM6AAAAABHD3O2VGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJYGQZTOMRZGU. You are receiving this because you were mentioned.Message ID: @.***>

eaj40 commented 5 months ago

Please see my comments

  1. The Lifecycles of the DLT must be identified [joe] resets when connected over TCP is identified

  2. Sorting by timestamp must be done based on the identified lifecycles

[joe] Sorting by timestamp starts from 0, after reset. This is already supported feature

Sent from Mailhttps://go.microsoft.com/fwlink/?LinkId=550986 for Windows

From: Alexander Wenzel @.> Sent: Tuesday, May 7, 2024 7:10:45 PM To: COVESA/dlt-viewer @.> Cc: eaj40 @.>; Mention @.> Subject: Re: [COVESA/dlt-viewer] fix Sorting by Lifecycle, startup time #307 (PR #463)

@eaj40https://github.com/eaj40 I still do not know how this PR will solve the issue. Identifying lifecycles in a DLT file is a complex topic and cannot be solved by a single line.

  1. The Lifecycles of the DLT must be identified
  2. Sorting by timestamp must be done based on the identified lifecycles

— Reply to this email directly, view it on GitHubhttps://github.com/COVESA/dlt-viewer/pull/463#issuecomment-2098437295, or unsubscribehttps://github.com/notifications/unsubscribe-auth/ADY65DHHBMGYENBY6LUZFDDZBDKV3AVCNFSM6AAAAABHD3O2VGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDAOJYGQZTOMRZGU. You are receiving this because you were mentioned.Message ID: @.***>

eaj40 commented 5 months ago

Resets when connected over following, does it complete lifecycles Serial INTERFACETYPE_UDP INTERFACETYPE_TCP