Revert "Revert Rename of dlt_common. (#512)"

COVESA / dlt-viewer

Diagnostic Log and Trace viewing program

Other

425 stars 240 forks source link

Revert "Revert Rename of dlt_common. (#512)" #513

Open LocutusOfBorg opened 1 month ago

LocutusOfBorg commented 1 month ago

This reverts commit a3ad76c19cea1a52a8870d435e6cb4f1de4d2621.

LocutusOfBorg commented 1 month ago

reopened

alexmucde commented 1 month ago

Thanks, i reverted already with this PR #512

LocutusOfBorg commented 1 month ago

So, can you please explain what broke? We should really convert it into a c++ file, if containing c++ code, right?

alexmucde commented 4 weeks ago

@LocutusOfBorg Sorry i have not much tiem at the moment. The Windows build was not working, thats why i have reverted it. If you can also have a look into Windows would be nice.

LocutusOfBorg commented 4 weeks ago

@alexmucde does the pipeline have some link? I don't have any windows machine, nor I know how to build, but if the pipeline runs on GitHub I can try to fix...