search

COVESA / dlt-viewer

Diagnostic Log and Trace viewing program
Other
439 stars 243 forks source link

No commnandline output when starting dlt-viewer without option from commandline in Windows #517

Closed alexmucde closed 2 months ago

vifactor commented 2 months ago

There is nothing printed after this line: https://github.com/COVESA/dlt-viewer/blob/cd2d1ffb963c8dcfac42db3a4baf96fa05518de5/qdlt/qdltoptmanager.cpp#L292

If I remove it, I can see full output, but of course then if executable is launched not from console but via double click, the console appears.

In any case, shouldn't the log output be redirected in a log file...

alexmucde commented 2 months ago

You are right. Command line mode is only activated in specfic use cases like, like -c conversion. Should we introduce a new command line option to activate command line mode?

vifactor commented 2 months ago

Should we introduce a new command line option to activate command line mode?

do you mean that if dlt-viewer is launched as follows from a cmd like .\dlt_viewer -c, then we do not call FreeConsole(); and hence qDebug prints messages into console? It is probably ok solution for now to give Windows users possibility to see log output, e.g. to troubleshoot an issue.

In the mean time, as I said above, it would probably be good to think about implementing file logging, since such persistent logs can be helpful for troubleshooting and bug analysis.

I'll make a PR with -c option soon to try

vifactor commented 2 months ago

-c option is occupied, but I'll try another solution around this: https://stackoverflow.com/questions/9009333/how-to-check-if-the-program-is-run-from-a-console