search

COVESA / dlt-viewer

Diagnostic Log and Trace viewing program
Other
425 stars 240 forks source link

fix signal for socket error #519

Closed vifactor closed 2 days ago

vifactor commented 1 month ago

The QAbstractSocket::error signal existed in Qt<5.15, but was renamed to QAbstractSocket::errorOccured probably to avoid https://stackoverflow.com/a/48250710

Since the codebase still uses the old style of connections the compiler could not detect that signal does not exist anymore and error was reported only on runtime: "qt.core.qobject.connect: QObject::connect: No such signal QTcpSocket::error(QAbstractSocket::SocketError)"

alexmucde commented 4 weeks ago

Need to be tested before integration. Do you have tested this?

vifactor commented 4 weeks ago

Yes, this is tested with qt5.15 and qt6. It will not work with qt less or equal to 5.12. if it is important to keep backward compatibility with those old qt version, this can be done with defines.

alexmucde commented 3 days ago

@vifactor Please add your signed off statement to the commit message.

vifactor commented 3 days ago

sorry, done!

alexmucde commented 13 hours ago

Causes now build issues with Ubuntu 20.04, still uses Qt 5.12.8. Still a lot of users using Ubuntu 20.04 on our side, maybe revert and new PR for later integration?

vifactor commented 13 hours ago

Ok, I see, I'll did not know 5.12 is still in use. I'll prepare a PR handling properly different Qt versions.