COVESA / franca_ara_tools

Translation between Franca Interface Description Language and AUTOSAR XML interface description language
Eclipse Public License 2.0
43 stars 13 forks source link

Feature/f2a/aspects on imports #93

Closed MLanghammer closed 5 years ago

MLanghammer commented 5 years ago

The PR introduces code to deal with the creation of multiple autosar files from multiple franca files. Note: needs to be merged after feature/aspects-on-imports

MLanghammer commented 5 years ago

Hi, I adressed all comments except the following:

* The test base methods contain a lot of code that is redundant with code in "AbstractFaraconConverter.xtend". Test methods should call 'AbstractFaraconConverter.convertFiles' instead as the test project is dependent on the project "org.genivi.faracon.cli" anyway. The public visibility of 'AbstractFaraconConverter.createResourceSet' and 'AbstractFaraconConverter.resolveProxiesAndCheckRemaining' indicates this issue as well.
MLanghammer commented 5 years ago

There should be added a comment why the additional model parameter has been added to the method 'FrancaImportCreator.createAndAddImportTo'. Otherwise it will be reactored to use the class attribute 'currentModel' directly instead. All other changes look good.

Good point - did that :)