search

COVESA / uservices

uServices - Open Vehicle Interfaces
Apache License 2.0
9 stars 8 forks source link

no external references in Proto #17

Open eriksven opened 3 weeks ago

eriksven commented 3 weeks ago

It would be great if the Proto files in this repository did not reference or import external proto files.

At the moment, some (missing) files are part of the dependencies that are downloaded during the Maven Build. However, this has some shortcomings when working with another programming language like Rust in my case.

An example setup would be to reference this uservices repository as sub-module in Git and then integrate the generation of the Rust stubs as part of the build process (in case of Rust cargo). At least, in that scenario the following two files are missing: 

google/rpc/status.proto: File not found.
uprotocol/uoptions.proto: File not found.

I understand that it is not the best idea to replicate the same files in this repository. One potential resolution could be to create a script which allows the developer to download the required missing proto-files from the respective sources and could be integrated in any kind of build automation.

What do you think?

eriksven commented 3 weeks ago

For reference, the uoptions.proto is available here:

https://github.com/eclipse-uprotocol/up-spec/blob/main/up-core-api/uprotocol/uoptions.proto