search

COVESA / vehicle-edge

Vehicle Edge is a software stack, which acts as an interface between vehicle specific data sources and vehicle agnostic applications
Mozilla Public License 2.0
16 stars 7 forks source link

Add iot-event-analytics submodule #27

Closed mariaivanova-git closed 3 years ago

mariaivanova-git commented 3 years ago

Creating a submodule of iot-event-analytics initially set at https://github.com/GENIVI/iot-event-analytics/pull/23 commit (before the ProtocolGateway change).

Signed-off-by: Maria Ivanova maria.ivanova@bosch.io

gunnarx commented 3 years ago

OK, I assume the intention is to use the submodule instead of a separate git clone of iot-event-analytics.

In that case, I would propose you also update the docker-compose README at the same time. Should these lines change?

"Clone the IoT Event Analytics repository into using git" and "_Update the IOTEA_PROJECTDIR variable in the .env file to the location where you cloned the IoT Event Analytics repository".

Maybe there is a way to use the submodule location instead of setting IOTEA_PROJECT_DIR, or to point IOTEA_PROJECT_DIR to a relative location.

... and consider if there are more behavior changes, for example:

"_If you do not want to clone it manually from https://github.com/GENIVI/iot-event-analytics, the given IOTEA_PROJECTDIR directory will be created and the repository will be cloned" - is no longer needed?