COVESA / vehicle_signal_specification

Vehicle Signal Specification - standardized way to describe automotive data
Mozilla Public License 2.0
326 stars 168 forks source link

Support negative torque for combustion engine #665

Closed ppb2020 closed 1 year ago

ppb2020 commented 1 year ago

Some combustion engine vehicles report a negative torque under braking conditions. This cannot be properly reflected by the current definition of engine torque as it is an unsigned integer.

This change proposes modifying the combustion engine torque definition from an unsigned integre to an integer.

Signed-off-by: Pierre Pierre Blais ppblais@BlackBerry.com

erikbosch commented 1 year ago

Based on previous discussions this would be considered as a major change as we change signal type, i.e. intended only for 5.0, not 4.1

No sign-offs in commits, that is why the DCO check fails. I noticed however that the guidelines does not specify that well if sign off should be in PR or commit(s). (FYI: @paulboyes ) But as I remember we have said that it should be in commits.

ppb2020 commented 1 year ago

I presume that I can add a commit with just a comment, so that the sign off is in a commit.

erikbosch commented 1 year ago

Meeting notes:

erikbosch commented 1 year ago

Meeting notes:

erikbosch commented 1 year ago

@ppb2020 - have you checked if you can update the PR/commit, or should I assist with a "workaround"?

ppb2020 commented 1 year ago

I have not been able to resolve the squashing issue as I always end up with two commits. Closing the PR. Will resubmit the change.