Feature/structure engine fluids

COVESA / vehicle_signal_specification

Vehicle Signal Specification - standardized way to describe automotive data

Mozilla Public License 2.0

307 stars 157 forks source link

Feature/structure engine fluids #710

Closed kowend closed 3 months ago

kowend commented 5 months ago

Several engine oil and coolant related attributes where spread in the main branch of the combustion engine. The engine oil and coolant have been put under a branch. Additional coolant lifespan and level (ISO 7000 2429) have been added under the coolant branch.

erikbosch commented 5 months ago

Topics to discuss:

This is right now considered as a "major" change (to be included in a major release only) as some signals will change name
Alternatively, one could for now "keep" the old names (in addition to the new ones) but mark them as deprecated

kowend commented 5 months ago

I think marking them as deprecated is fine, and leave them in. Is there any standard/rule for removing deprecations? I can imagine we don't want too many deprecations left in the specs.

For which version would these signals then be deprecated?

kowend commented 5 months ago

Ah nevermind about the rule for deprecation. I found the description in the basics.md. But knowing the version for deprecation would still be useful. Would that be v5.0?

erikbosch commented 5 months ago

Ah nevermind about the rule for deprecation. I found the description in the basics.md. But knowing the version for deprecation would still be useful. Would that be v5.0?

Possibly. Historically we have selected "next release" as "deprecated from", but right now we have not really decided if we will release a 4.2 or if next release will be 5.0. I would say that 5.0 is the best option for now for main, if we decide to create a 4.2 then we as maintainers should anyway check all deprecation comments and adjust version if needed, like replacing 5.0 with 4.2 for the maintenance branch.

kowend commented 5 months ago

Clear! I'll add the deprecation attributes. I've realised that the electrical motor could also have a cooling compartiment. At least the coolant temperature is mentioned as an optional. I've moved the coolant branch into a separate spec file.

erikbosch commented 5 months ago

MoM:

Please review

erikbosch commented 4 months ago

MoM:

Pierre Pierre not present
Merge decision next week unless comments/remarks

erikbosch commented 4 months ago

MoM:

Pierre on vacation, keep open. He is back next week

erikbosch commented 4 months ago

MoM:

Possible merge decision next week
@ppb2020 could you check if it is ok

ppb2020 commented 4 months ago

I have no further comments. I am fine with the responses that were provided, with a note that I am still slightly in favour of reusing the set of enum values, but not enough to block merge.

erikbosch commented 4 months ago

MoM:

Merge