Add screen mirroring in Infotainment.vspec

COVESA / vehicle_signal_specification

Vehicle Signal Specification - standardized way to describe automotive data

Mozilla Public License 2.0

307 stars 157 forks source link

Add screen mirroring in Infotainment.vspec #737

Closed spshin3 closed 1 month ago

spshin3 commented 2 months ago

This PR is rework of PR #699 . The type of SmartphoneScreenMirroring.Resolution is changed to 'sensor'.

The differences of smartphone screen mirroring with smartphone projection as follow: Screen Mirroring, such as through AirPlay, mirrors all activities of a device’s screen, allowing every detail to be displayed on a secondary screen. On the other hand, existing Projection specifically targets in-vehicle use, selectively providing access to certain applications in smartphone like navigation and music players. Specifically, Screen Mirroring enables the casting of applications not typically offered by Projection, such as 'YouTube', to a vehicle's display. Therefore, Screen Mirroring and Projection are parallel technologies, each serving distinct use cases without overlapping functionalities.

erikbosch commented 2 months ago

MoM

WI-FI/WIFI
PP: No major preferences, we could align with old `WIFI
Stefan: Does not matter
Erik: Please review/discuss, continued discussion next meeting

spshin3 commented 2 months ago

I resolved the DCO error before the meeting. Thanks for your summary.

MoM

WI-FI/WIFI

PP: No major preferences, we could align with old `WIFI

Stefan: Does not matter

Erik: Please review/discuss, continued discussion next meeting

erikbosch commented 2 months ago

Trying to summarize my view on this PR.

At last meeting we agreed to use WIFI rather than WI-FI to avoid changing name of other already existing signals using WIFI
For the other signal, maybe we should clarify that the signal concerns currently used resolution to avoid ambiguity

At next meeting I suggest that we agree on remaining needed changes (if any) , so that we can merge it as soon as they have been fixed

spshin3 commented 1 month ago

MoM

WI-FI/WIFI

PP: No major preferences, we could align with old `WIFI

Stefan: Does not matter

Erik: Please review/discuss, continued discussion next meeting

Thanks for your clarification.

In my personal opinion, resolving the ambiguity surrounding 'resolution' is challenging in our current signal. This is because, we don't have a specific signal for display-related and resolutions with in our spec.

I think for this issue, we need to discuss adding the display-related signal before. Once this is added, we can clarify what 'resolution' means in the context of screen mirroring.

Therefore, my suggestion for this PR is removing the resolution signal for this time. And I will prepare another PR for the display related signal for the infotainment system.

Thanks.

erikbosch commented 1 month ago

MoM:

OK to merge if resolution signal removed
Richard Fernandes - Resolution can be complex due to DRM, we from AOSP could possibly contribute

spshin3 commented 1 month ago

MoM:

OK to merge if resolution signal removed

Richard Fernandes - Resolution can be complex due to DRM, we from AOSP could possibly contribute

Thanks for your feedback and the decision. I just removed the resolution in my PR.