search

COVESA / vsomeip

An implementation of Scalable service-Oriented MiddlewarE over IP
Mozilla Public License 2.0
1.09k stars 678 forks source link

Question about e2e profile 4 #240

Closed xbroquer closed 3 years ago

xbroquer commented 3 years ago

Hello,

First of all thank you very much for implementing e2e profile 4 protection!

I have a question about e2e header generation and more precisely on data_id , for SWS_E2E_00366 req :

https://github.com/GENIVI/vsomeip/blob/13f9c89ced6ffaeb1faf485152e27e1f40d234cd/implementation/e2e_protection/src/e2e/profile/profile04/protector.cpp#L37

https://github.com/GENIVI/vsomeip/blob/13f9c89ced6ffaeb1faf485152e27e1f40d234cd/implementation/e2e_protection/include/e2e/profile/profile04/profile_04.hpp#L15

I were not able to find the Req that impose to add the instance ID in MSB of data id.

Here the document I used to check the implementation: https://www.autosar.org/fileadmin/user_upload/standards/classic/4-2/AUTOSAR_SWS_E2ELibrary.pdf

Do you have some detail why you added the instance id ?

Thanks, Xavier.

xbroquer commented 3 years ago

Follow up :)

@lutzbichler Can you please clarify this particular point ? I just forked this repo to only remove the instance_id in order to get e2e profile working on my side.

lutzbichler commented 3 years ago

The instance ID was added to avoid using the same data id for different instances of the same service. We will make this optional.

xbroquer commented 3 years ago

thanks , having this optional will be fine