search

COVESA / vsomeip

An implementation of Scalable service-Oriented MiddlewarE over IP
Mozilla Public License 2.0
1.01k stars 647 forks source link

Initialize the routing running state #655

Open kheaactua opened 2 months ago

kheaactua commented 2 months ago

The routing manager running state appears uninitialised, which can (and has) resulting in routingmanagerd starting up in a suspend state.

gunnar-mb commented 1 month ago

General question on this and #653: How is this not caught by compiler warnings or static-analysis evaluation?
(We shouldn't have to deal with trivial things like uninitialized variables, right?)

kheaactua commented 1 month ago

General question on this and #653: How is this not caught by compiler warnings or static-analysis evaluation? (We shouldn't have to deal with trivial things like uninitialized variables, right?)

A lot of https://github.com/COVESA/vsomeip/pull/560 was addresses the results from cppcheck, but either I missed this, or I mainly focused on shadowing, or maybe I first ran this on 3.1.20 which didn't have this member.

But yeah, I was also wondering why I didn't notice this last time I ran static-analysis. :(