search

COVESA / vsomeip

An implementation of Scalable service-Oriented MiddlewarE over IP
Mozilla Public License 2.0
1.1k stars 691 forks source link

[BUG]: Find Service with multicast enabled, vsomeip stack always send unicast offer service #753

Open SarbeenaS opened 2 months ago

SarbeenaS commented 2 months ago

vSomeip Version

v3.4.10

Boost Version

1.76

Environment

Ubuntu and Android

Describe the bug

Find Service with multicast enabled, vsomeip stack always send unicast offer service Find_Unicast

Reproduction Steps

No response

Expected behaviour

No response

Logs and Screenshots

No response

vidz12 commented 1 month ago

Below two changes are done in service_discovery_impl class,

image (9)

  1. In send_uni_or_multicast_offerservice() function, send_multicast_offer_service(_info) is added if unicast_flag comes with value 0

  2. In send_multicast_offer_service function, serialize_and_send() is modified to accept sd_multicastaddress as address param.

And it is working for us. i.e. OFFER() is sent over multicast when FIND() is triggered with UNICAST flag set as 0