COVESA / vss-tools

Software for working with VSS (https://github.com/COVESA/vehicle_signal_specification)
Mozilla Public License 2.0
51 stars 55 forks source link

Remove vss-tools dependency to VSS #288

Closed erikbosch closed 1 year ago

erikbosch commented 1 year ago

As of today we have a sort of circular dependency

Would it be an idea to try to break up this dependency? My idea - for now - is to remove CI dependency towards VSS repo.

In short:

I.e. remove the following lines (and some more) from vss-tools CI:

     - name: Test mandatory targets
        run: |
          cd ${{ env.VSS_TOOLS_PATH }}
          pipenv run make -C "${{ env.VSS_PATH }}" travis_targets
      - name: Test optional targets.
        run: |
          cd ${{ env.VSS_TOOLS_PATH }}
          pipenv run make -C "${{ env.VSS_PATH }}" -k travis_optional ||
            echo "::warning title=travis_optional::optional targets FAILED"

This would simplify cases where we today need to change Makefile as the repos then typically get out of synch with temporary build errors until both repos are updated . We might need/want to move some parts to vss-tools at the same time, like how to build binary tools.

This is a little related to #121.

erikbosch commented 1 year ago

Fixed by #294