search

COVESA / vss-tools

Software for working with VSS (https://github.com/COVESA/vehicle_signal_specification)
Mozilla Public License 2.0
54 stars 55 forks source link

Fix hard-coded username in pipenv installation instructions #335

Closed ppb2020 closed 6 months ago

ppb2020 commented 6 months ago

Copy/pasting the instructions for installing pipenv fail because of a hard-coded /home/user, forcing user to modify the instructions before executing the command. This can be addressed by using the ${USER} environment variable.

Signed-off-by: Pierre Pierre Blais ppblais@blackberry.com

erikbosch commented 6 months ago

The failed DCO check likely depends on that the "author field" of the commit does not match sign-off. Have there possibly been any rebase/edit in Github UI. I anyway do not see this as a real blocker, so no reason to spend too much time on fixing it.

image

ppb2020 commented 6 months ago

Weird; I used the same sign-off as I had used in my last commit...

Looks like if "ppb2020 [66322482+ppb2020@users.noreply.github.com]" was expected... Perhaps I should use this in the future?

erikbosch commented 6 months ago

Weird; I used the same sign-off as I had used in my last commit...

Looks like if "ppb2020 [66322482+ppb2020@users.noreply.github.com]" was expected... Perhaps I should use this in the future?

Nah, I think it just expects them to match. But I have seen "authors" like that previously when someone has done anything in the UI, like explicit/implicit rebase/squash and similar. But no big deal as I see it - there is a signoff and the signoff shows your real name so I consider the reported error more like a false positive

ppb2020 commented 6 months ago

Ah, yes. As this was a very simple patch and only affecting documentation, I used the GitHub Web GUI to make the change as opposed to making the change locally on my development host. That was certainly a difference from my previous submissions.

erikbosch commented 6 months ago

MoM: Merge