COVESA / vss-tools

Software for working with VSS (https://github.com/COVESA/vehicle_signal_specification)
Mozilla Public License 2.0
49 stars 51 forks source link

use apt for pipenv install #350

Closed nwesem closed 2 months ago

nwesem commented 2 months ago

https://github.com/COVESA/vss-tools/blob/master/README.md#setup-using-venv

didn't work for me on a clean ubuntu 24.04 install, needed to install pipenv using apt so i would suggest changing this

export PIPENV_VENV_IN_PROJECT=1 # will create a local `.venv` in the project, otherwise uses global location
pip install pipenv
export PATH=/home/${USER}/.local/bin:${PATH}
pipenv install --dev # install the development dependencies as well

to

export PIPENV_VENV_IN_PROJECT=1 # will create a local `.venv` in the project, otherwise uses global location
sudo apt update && sudo apt install pipenv
export PATH=/home/${USER}/.local/bin:${PATH}
pipenv install --dev # install the development dependencies as well
erikbosch commented 2 months ago

I think a change like that makes sense, I think that pip in at least newer versions refuse to install things like pipenv globally, i.e. if you use the default Python/Pip. Feel free to create a PR:

nwesem commented 2 months ago

while we're at it, I realized that we are missing dev dependencies. in particular we are missing golang-go and protobuf-compiler to make the tests succeed, do you agree that we should add them in the code block above the one mentioned here @erikbosch

erikbosch commented 2 months ago

We have some info at https://github.com/COVESA/vss-tools/blob/master/README.md#installing-additional-tools It mentions protobuf-compiler there, but not golang-go. Feel free to move that information to some other place if you like.