COVESA / vss-tools

Software for working with VSS (https://github.com/COVESA/vehicle_signal_specification)

Mozilla Public License 2.0

49 stars 51 forks source link

Using rich for logging format, added .envrc #366

Closed sschleemilch closed 3 weeks ago

sschleemilch commented 1 month ago

About

Using rich as logging formatter for readability.

Before:

After:

Also added an direnv config for python3. Added gitignore entry accordingly

erikbosch commented 4 weeks ago

MoM: Please review

sschleemilch commented 3 weeks ago

Any findings? If not, mergy merge? :octocat:

erikbosch commented 3 weeks ago

Any findings? If not, mergy merge? :octocat:

Unless a PR is trivial we typically give people a week for reviewing, i.e. announcing at one VSS Tuesday meeting, and then taking a merge decision at the next, or the day before if there is nothing reported. For larger ones possibly even longer review time.

In this case (as it is quite technical) i do not think discussing it again at next meeting makes sense, but I will wait until Monday to see if anyone has any objections.

sschleemilch commented 3 weeks ago

Any findings? If not, mergy merge? :octocat:

Unless a PR is trivial we typically give people a week for reviewing, i.e. announcing at one VSS Tuesday meeting, and then taking a merge decision at the next, or the day before if there is nothing reported. For larger ones possibly even longer review time.

In this case (as it is quite technical) i do not think discussing it again at next meeting makes sense, but I will wait until Monday to see if anyone has any objections.

Okay, I thought this one's pretty trivial but all good

erikbosch commented 3 weeks ago

The weekend has passed and no-one has filed any additional comments. Looks good to me, merging so that you can rebase the other PR.