Open nwesem opened 3 months ago
Would this be valid .idl
output including staticUIDs? for leaves it should be correct, but I'm currently wondering how to attach the static UIDs to branches, would it work like shown below?
Sadly, I can't get the idlc
parser to run it even seg faults from a file generated from master branch..
module Vehicle
{
const string staticUID ="0x35AFD7A7";
module ADAS
{
const string staticUID ="0x206A4E82";
module ABS
{
const string staticUID ="0xCE6D5634";
struct IsEnabled
{
boolean value;
const string type ="actuator";
const string description ="Indicates if ABS is enabled. True = Enabled. False = Disabled.";
const string staticUID ="0x6BAFEF4E";
};
struct IsEngaged
{
boolean value;
const string type ="sensor";
const string description ="Indicates if ABS is currently regulating brake pressure. True = Engaged. False = Not Engaged.";
const string staticUID ="0xAAF08F7B";
};
struct IsError
{
boolean value;
const string type ="sensor";
const string description ="Indicates if ABS incurred an error condition. True = Error. False = No Error.";
const string staticUID ="0x75B9DC6A";
};
};
MoM: Let's have a look.. We need time to review this.
hi @erikbosch, do you have any info on the (dds)idl exporter? could you take a quick look at my comment above? Maybe you have an idea how to add attributes to branches in idl files? For me there is no way to check if my implementation is correct as I can't get the idlc
parser running (seems like the documentation is outdated)..
Edit: In case you are not that familiar with the (dds)idl related code maybe there is somebody else in covesa that is?
hi @erikbosch, do you have any info on the (dds)idl exporter? could you take a quick look at my comment above? Maybe you have an idea how to add attributes to branches in idl files? For me there is no way to check if my implementation is correct as I can't get the
idlc
parser running (seems like the documentation is outdated)..Edit: In case you are not that familiar with the (dds)idl related code maybe there is somebody else in covesa that is?
I do not think that anyone has worked on DDSIDL lately. I do not think the structs support const
, that is why they add that as comment in generator
struct Minor
{
unsigned long value;
//const string type ="attribute";
//const string description="Supported Version of VSS - Minor version.";
};
I created a simple test case in #379 to update instructions, they seemed to be mashed up. Also a simple test case to verify that output is accepted. I honestly do not know if the ddsidl generator is useful as of today, or if it rather should be deprecated.
Conflicts! Also added @UlfBj as reviewer as it concerns the "binary" tool quite a lot. Ulf - could you check how much implications this would have for VISSR. As it is for a major VSS(tools) release I guess that some required changes in VISSR is acceptable.
Conflicts!
Yes I already rebased once will do it again later today
@nwesem - still conflicts
MoM:
Changes:
How to verify:
First you have to create an ID file with
Now we check all exporters:
If you want to test that it still works without staticUIDs:
try csv export and check results
try idl export
try franca export
try graphql export
try json export
try protobuf export and check results
try yaml export