Redesigned CLI

[sschleemilch]

Fixes #372 Fixes #345 Fixes #339

Cli using click

Root:

Export:

Exporter (JSON):

[!WARNING] Interface changes --include-dir -> --include-dirs -s --> --strict / --no-strict --abort-on-unknown-attribute -> --aborts unknown-attribute --abort-on-name-style -> --aborts name-style -q / --quantity_file -> --quantities / -q --unit_file -> --units / -u --gqlfield name description -> --qgl-field/-q name,description -vt / --vspec-types-file -> --types / -t -ot / --types-output-file -> --types-output --json-pretty -> --pretty --json-all-extended-attributes -> --extend-all-attributes --only-validate-no-export -> --validate-only --strict-mode -> --case-sensitive --jsonschema-disallow-additional-properties -> --no-additional-properties --jsonschema-require-all-properties -> --require-all-properties --jsonschema-pretty -> --pretty

[!NOTE] New arguments vspec export binary: --bintool-dll/-b

Todo

• [x] binary Docs
• [x] --strict-mode === --strict? -> --case-sensitive
• [x] better toplevel exporter Docs?
• [x] Port contrib/ Not needed. Still works!

[sschleemilch]

@erikbosch what to do with obsolete/ tools? I guess I should not port them, right? I did not check whether they work...

[erikbosch]

@erikbosch what to do with obsolete/ tools? I guess I should not port them, right? I did not check whether they work...

Just ignore them

[erikbosch]

MoM:

• Author presented behavior
• Sebastian ETAS: Does anyone would get into big problems with changed cli syntax?
• Niclas: Supports it.
• Erik: Please review, merge early next week if approved by maintainer and no open discussion topics

[erikbosch]

I do not really know why it still reports conflicts, anyhow leaving for the weekend now

[sschleemilch]

I do not really know why it still reports conflicts, anyhow leaving for the weekend now

It does not report conflicts for me. Maybe F5? Sure, let's check it again beginning of next week.

[erikbosch]

This is how it looks like for me

The Github UI merge/rebase sometimes have its limitations. I tried manually to do a rebase and a squash to get a clean history and it seems to to be the poetry.lock file that causes the conflict.

git rebase upstream/master
poetry lock
git add poetry.lock 
git rebase --continue
git rebase -i HEAD~17

I uploaded the result at #383 for reference. Do you have a strong opinion whether all you commit shall be kept (as is) or not? I have a slight preference for squashing them like in #383 but it is not a strong opinion. I think the PR looks good now, no outstanding topics, so ready for merge. I see two options, either we can merge from #383 or if you do a rebase with main (plus possibly squash) and force push it to your branch

[erikbosch]

And I noticed that it is actually only the "rebase&merge" alternative that is disabled, the other works. But I try to avoid merge commits when possible/feasible. Squash is enabled in UI, so I could do it that way as well if you think squash is reasonable

[sschleemilch]

And I noticed that it is actually only the "rebase&merge" alternative that is disabled, the other works. But I try to avoid merge commits when possible/feasible. Squash is enabled in UI, so I could do it that way as well if you think squash is reasonable

@erikbosch I am fine with squash merging 👍

[erikbosch]

Ok, then I might try squash&merge after lunch. We can anyway handle any regressions afterwards, if something unexpected would happen