search

COVESA / vss-tools

Software for working with VSS (https://github.com/COVESA/vehicle_signal_specification)
Mozilla Public License 2.0
55 stars 55 forks source link

Improve documentation/test of -e #381

Closed erikbosch closed 2 months ago

erikbosch commented 2 months ago

Recent change for CLI change how -e must be used, like:

As this is a backward incompatible change it might be good to give a warning. This PR assumes valid extra arguments ever contain a comma, and adds some tests

sschleemilch commented 2 months ago

378 introduces that already: https://github.com/COVESA/vss-tools/pull/378/files#diff-b6edd36e3b26ecd6c94d19d1a0484fce6cbb7f88d11330368b6b55666afb5daeR37

erikbosch commented 2 months ago

Duplicate #378

Greats minds thinks alike. I will review that one now!

sschleemilch commented 2 months ago

Duplicate #378

Greats minds thinks alike. I will review that one now!

Just merged master, we had merge conflits with #379.

erikbosch commented 2 months ago

Putting this one on hold for now. I can confirm that repeated -e works in the other PR. The test cases from this PR and some of the documentation updates might be relevant to keep, I will visit it again after the other is merged.

erikbosch commented 2 months ago

@sschleemilch - reworked this one now. I think it could be useful to give an error if someone use the old syntax with comma