search

COVESA / vss-tools

Software for working with VSS (https://github.com/COVESA/vehicle_signal_specification)
Mozilla Public License 2.0
55 stars 55 forks source link

Add a new exporter for ApiGear solution #391

Closed kamil-machnicki-siili closed 1 month ago

kamil-machnicki-siili commented 2 months ago

Siili Auto collaborative changes, contributors:

Export the VSS project to a folder containing a solution and module files used as input for ApiGear generator.

Right now, it generates code using the following templates:

erikbosch commented 2 months ago

MoM:

Please review

erikbosch commented 2 months ago

Thank you for contribution. I noticed it just before the weekly VSS meeting yesterday and there I asked people to review it. Would you be interested in providing some more background on https://apigear.io/ and how the extension in this PR is supposed to be used. The COVESA VSS-project has a weekly meeting at Tuesdays 16.00 Central European Time, connection details available in the COVESA calendar at https://wiki.covesa.global/display/WIK4/COVESA+Common+Meeting+Schedule and it would be great if you would have the possibility to join and give some background to your work and answer questions, if any. If you intend to join a meeting in the near future me or one of the other VSS maintainers (@SebastianSchildt @adobekan ) could reserve some time for discussion. If you do not have the possibility to join it would be good to add some background information as a comment in this PR.

I took a quick look at the PR and I see in general no major problems. As you are first time contributor a maintainer need to approve any workflow run. In general our workflow for contributions is that we take merge decisions at the weekly VSS meetings, and aim to give members at least a week for review. As this PR introduces a new tool we may want to give a longer review period. there is a major rework of vss-tools going on in #382, so this one will need to be rebased when that one is merged, which possibly will happen next week.

Before accepting the PR I would like to know if you have the intention to continue supporting the new tool, like assisting if anyone has an issue with the tool or detects a bug, or if the tool needs to be refactored due to some general change in vss-tools. Just to make sure that the tool does not get abandoned in the near future.

kamil-machnicki-siili commented 2 months ago

@erikbosch thanks for your insights, for sure the exporter is meant to be used and maintained in the future. We've already had a chat within our team about the weekly VSS meeting and certainly someone from us will be there next Tuesday to give you more details on the topic and discuss the exporter and ApiGear usage.

adobekan commented 2 months ago

MoM: @sschleemilch we need your approval for this PR.

sschleemilch commented 1 month ago

Let me know if you need help adapting it to the major refactoring that just got merged on master

kamil-machnicki-siili commented 1 month ago

Let me know if you need help adapting it to the major refactoring that just got merged on master

Thanks @sschleemilch, I think I got it rebased properly.

kamil-machnicki-siili commented 1 month ago

Thanks for doing all the proposed fixes. 👍 From my side it is good now 🕺

Thank you @sschleemilch, I've just uploaded one last patch with changed deprecation handling as we had some name conflicts upon building and it should be all set from our side.

SebastianSchildt commented 1 month ago

MoM 08/27 Merge