Fixes for compiler warnings and c++ support

COVESA / vss-tools

Software for working with VSS (https://github.com/COVESA/vehicle_signal_specification)

Mozilla Public License 2.0

55 stars 55 forks source link

Fixes for compiler warnings and c++ support #413

Open eric-hologic opened 5 days ago

eric-hologic commented 5 days ago

The fix in 9fb1fc35e3d073e36ce71ad00a3143cd59ed8f8e looks like something to upstream. The others commits are FYI

erikbosch commented 4 days ago

Thanks for the pull request. I will bring it up for initial discussion at the next VSS meeting on Tuesday.

The DCO check fails. COVESA requires all contributions to be signed off. Please read https://covesa.global/about-covesa/#contribute-code After reading it add a sign-off to your commit git commit --amend -s and do a force push.

@UlfBj - could you possible assist with reviewing.

UlfBj commented 4 days ago

I am ok with having all the commits merged if that is what the commiter wants.

eric-hologic commented 4 days ago

Great - thank you. Added sign-off information to commits as requested.

erikbosch commented 23 hours ago

MoM: Merge